update to latest minimap2 (Minimap2-2.31 (r1302))#163
Open
rob-p wants to merge 2 commits into
Open
Conversation
… 2.31)
minimap2 2.31 dropped the bundled `lib/simde` submodule (it now ships only a
standalone Makefile.simde and expects the consumer to provide simde), so the
`simde` feature's `cc.include("minimap2/lib/simde")` pointed at a path that no
longer exists, failing with:
minimap2/ksw2_ll_sse.c:7:10: fatal error: simde/x86/sse2.h: No such file or directory
Add simde as a minimap2-sys submodule (simd-everywhere/simde, pinned to v0.8.2)
and include it from build.rs instead. Exclude its test/ dir from the published
package (mirrors the old /minimap2/lib/simde/test exclude); packaged size stays
~1 MiB compressed. Verified `cargo test --features simde` passes for both
minimap2-sys and the top-level minimap2 crate.
Owner
|
Will get onto this this week. Also thanks for publishing the https://github.com/COMBINE-lab/OUP-Bioinformatics-Typst repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the associated minimap2 version to Minimap2-2.31 (r1302), which includes the bug fixes upstreamed during rammap development.