Add custom Opsin Inverse Matrix (XYB Color Bias tuning)#4813
Draft
Galaxy4594 wants to merge 10 commits into
Draft
Add custom Opsin Inverse Matrix (XYB Color Bias tuning)#4813Galaxy4594 wants to merge 10 commits into
Galaxy4594 wants to merge 10 commits into
Conversation
6e49dd0 to
665add9
Compare
also a quick mention of a spec limitation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API additions allowing the user to manually tune the RGB -> LMS color pipeline.
JXL_ENC_FRAME_SETTING_COLOR_BOOST: A boolean toggle that applies a scalingyellow_biasbased on quantization.JXL_ENC_FRAME_SETTING_RED_BIAS: Float value to tune the L-cone multiplier.JXL_ENC_FRAME_SETTING_GREEN_BIAS: Float value to tune the M-cone multiplier.JXL_ENC_FRAME_SETTING_YELLOW_BIAS: Float value to tune the S-cone multiplier.New CLI Flags has been added to cjxl to accompany these new API features:
--color_boost: Appliesyellow_biaswhich fixes the yellow desaturation issues present. The strength increases with quantization.--red_bias <float>, --green_bias <float>, --yellow_bias <float>: Manually tune individual cone responses.This code is AI-assisted and I didn't have time to comb through the slop yet.
Fixes: #3616 and possibly other color related issues.