Fix S2 comparison map embed#1167
Open
NjengaC wants to merge 3 commits into
Open
Conversation
Update the S2 comparison iframe to use the current Foursquare Studio embed URL and add an iframe title for accessibility.
fix: Fix S2 comparison map embed
|
|
isaacbrodsky
approved these changes
May 29, 2026
Collaborator
|
Does this need to be updated for the other studio.unfolded.ai embeds? |
|
coverage: 99.162%. remained the same — NjengaC:master into uber:master |
Author
I found the other I may have been seeing a local/browser-specific loading issue, so this is probably better framed as updating stale Studio embed URLs rather than fixing a consistently reproducible browser issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S2 comparison page currently embeds the comparison map using the old
studio.unfolded.aiURL. In Chrome, the iframe area appears blank on the live docs page.This updates the iframe to the current
studio.foursquare.comembed URL. I also added atitleattribute to the iframe for accessibility.I verified the updated embed URL manually by loading it in a local HTML file in the browser.