ames: drop %goad if duct is missing#7320
Draft
yosoyubik wants to merge 4 commits into
Draft
Conversation
Collaborator
Author
|
We need to understand a bit better the root cause of this issue before merging the fix in this PR. It seems that the most likely scenario are %kicks that get automatically acked in %ames, when %leave pleas are outstanding and flubbed, but that would prevent anything to be send. The behavior before this PR is the right one for now: we need to be able to identify the issue instead of silently no-op/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for: https://pastebin.com/1uTHdPQq
Different flow analysis that could trigger this issue:
Scenario A)
------------- SUSPENSION
Scenario B)
agent gets revived
host sends %kick
subscription gets removed on host
the app gets suspended
kick arrives before %boon %flub
subscription gets removed, we send a %cork
%corks don't go into %gall, so all gets resolved silently, the flow is removed
before %kick arrives we enqueue a %leave
A) - %leave plea gets nacked non-deterministically, we retry
B) - %leave gets handled, and flubbed
%kick arrives when the %leave it's still outstanding
the host revives the agent and sends a %boon %spur.
the subscriber handles the %boon on the %gf flow, gives to %gall. %gall then retrieves the saved duct from state, gives to %ames. %ames has corked the flow, the duct is gone: we crashed as seen in the pastebin.