Do not mask error when ignore_cassettes is true#952
Open
stephenprater wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When turning VCR cassettes off and using
ignore_cassettes: trueanyuse_cassetteblocks will be executed as normal. But if an error is raised within the test - that error will be caught in theuse_cassettemethod. The cassette in this method will not exist, because theignore_cassettesflag causes it to not be inserted. ANoMethodErrorwill be raised when VCR attempts to callrun_failed!on the non-existent cassette.Let's use the safe navigation operator to conditionally not mark a cassette as failed if it doesn't exist!