ci: add read-only token permissions and pin actions/checkout to SHA#101
Open
Alb3e3 wants to merge 1 commit into
Open
ci: add read-only token permissions and pin actions/checkout to SHA#101Alb3e3 wants to merge 1 commit into
Alb3e3 wants to merge 1 commit into
Conversation
Both CI workflows (autotools and cmake) lacked a top-level permissions block, leaving them to inherit the repository default (potentially write-all). Each now has `permissions: read-all` at the top level. The actions/checkout@v2 reference in both workflows was also pinned to the full commit SHA of the current v6.0.3 release, replacing the mutable version tag with an immutable reference that is immune to tag rewriting. Verified with zizmor --min-severity medium: no findings after this patch. Signed-off-by: Alb3e3 <tomaska.filip@gmail.com>
f3799b0 to
8cb5d8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both CI workflows (
autotools.ymlandcmake.yml) lacked a top-levelpermissions:block, leaving each run to inherit the repository default,which can be write-all on permissive settings. Each workflow now has
permissions: read-allat the top level.The
actions/checkout@v2reference in both workflows was also updated tothe current v6.0.3 release and pinned to its full commit SHA
(
df4cb1c069e1874edd31b4311f1884172cec0e10). Pinning to a SHA ratherthan a mutable version tag prevents the action from being silently changed
under the project.
Verification
Result: no findings after this patch.