Skip to content

Add helper methods to the TypesafeConfigReader.#440

Open
gorzell wants to merge 4 commits into
Netflix:2.xfrom
gorzell:gorzell-typesafeLoaderHelpers
Open

Add helper methods to the TypesafeConfigReader.#440
gorzell wants to merge 4 commits into
Netflix:2.xfrom
gorzell:gorzell-typesafeLoaderHelpers

Conversation

@gorzell

@gorzell gorzell commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

I added some helper methods and tests for them. There is probably a large issue around how to support this kind of thing in the interface, but I figure this was a good start.

@gorzell

gorzell commented Sep 23, 2016

Copy link
Copy Markdown
Contributor Author

@elandau can I get a review on this?

@elandau

elandau commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

@gorzell Sorry for taking so long to look at this. Can you please fix the conflict and I'll go ahead and merge.

@gorzell gorzell requested a review from elandau December 12, 2017 10:52
…feLoaderHelpers

# Conflicts:
#	archaius2-typesafe/build.gradle
@gorzell

gorzell commented Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

@elandau I fixed the conflict, but something seems to have gone sideways with the build, even the stable/previously successful branches no longer build on my laptop or in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants