[16.0][REF] shopfloor/shopfloor_reception: global boolean "allow_quantity_exceeding_demand" on all scenarios#1169
Conversation
|
Hi @JuMiSanAr, @mmequignon, |
|
Because of some error when rebasing, some code has been lost in here; 813c6da#diff-768e3710963536fd21aa34f807f18c34629399f77a1c5a463fa66b332aef5052 |
0dafd97 to
4ecf60a
Compare
4ecf60a to
f234f9d
Compare
jbaudoux
left a comment
There was a problem hiding this comment.
As you are on it, would it be possible to make the option agnostic of reception. Entering a quantity done bigger than the quantity to do is a standard feature valid for any operation type.
What about allow_quantity_exceeding_demand ?
Good idea, I'll do that |
f234f9d to
c090c30
Compare
5ff4e57 to
8b46862
Compare
8b46862 to
59cf48d
Compare
jbaudoux
left a comment
There was a problem hiding this comment.
Can you add the migration script like this one https://github.com/OCA/wms/blob/16.0/shopfloor_reception/migrations/16.0.1.3.0/post-migrate.py ?
59cf48d to
dc1e8ea
Compare
lmignon
left a comment
There was a problem hiding this comment.
LGTM. Thank you for this improvement @nicolas-delbovier-acsone ! (Code review)
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1169-by-jbaudoux-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Because of some error in rebasing, this commit 813c6da has deleted some code that should not have been.
…ion instead of using "reception only" setting
dc1e8ea to
66822b9
Compare
Make the
allow_over_receptionfield from reception scenario available to all scenarios and rename it toallow_quantity_exceeding_demandAlso includes : fix accidentally deleted code (from this PR: #1090)