[16.0][ADD] pos_product_sequence#997
Conversation
| max_sequence = self._cr.fetchone()[0] | ||
| if max_sequence is None: | ||
| return 10000 | ||
| return max_sequence + 5 |
There was a problem hiding this comment.
Do we need these computations? Was that copied from Website logic by chance?
I expected a default fixed sequence number, such as 1000.
Products with the same sequence number would just follow whatever default sort criteria is, if that's not a complication.
There was a problem hiding this comment.
I totally agree. A simple default value should be enough here.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
| max_sequence = self._cr.fetchone()[0] | ||
| if max_sequence is None: | ||
| return 10000 | ||
| return max_sequence + 5 |
There was a problem hiding this comment.
I totally agree. A simple default value should be enough here.
No description provided.