Skip to content

[FIX] pos_receipt_hide_info: remove question mark in field name.#1507

Open
legalsylvain wants to merge 1 commit into
OCA:16.0from
grap:16.0-FIX-pos_receipt_hide_info-remove-question-mark
Open

[FIX] pos_receipt_hide_info: remove question mark in field name.#1507
legalsylvain wants to merge 1 commit into
OCA:16.0from
grap:16.0-FIX-pos_receipt_hide_info-remove-question-mark

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor

Rational: In Odoo there is no boolean fields with question mark in the name. So we follow odoo / OCA convention and remove the character in the 3 fields and in the po / pot files.

@legalsylvain legalsylvain added this to the 16.0 milestone Mar 24, 2026

@flotho flotho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review
Thanks
LGTM

@legalsylvain

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1507-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 30, 2026
Signed-off-by legalsylvain
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1507-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain legalsylvain force-pushed the 16.0-FIX-pos_receipt_hide_info-remove-question-mark branch from 08dbbfc to e6abd3e Compare March 30, 2026 13:09

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1507-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 7, 2026
Signed-off-by ivantodorovich
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1507-by-ivantodorovich-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1507-by-ivantodorovich-bump-patch.

Oh. really ?

@legalsylvain

Copy link
Copy Markdown
Contributor Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1507-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1507-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Rational: In Odoo there is no boolean fields with question mark in the name.
So we follow odoo / OCA convention and remove the character in the 3 fields and in the
po / pot files.
@legalsylvain legalsylvain force-pushed the 16.0-FIX-pos_receipt_hide_info-remove-question-mark branch from e6abd3e to 2c6b74c Compare June 12, 2026 14:07
@OCA-git-bot OCA-git-bot added series:16.0 mod:pos_receipt_hide_info Module pos_receipt_hide_info labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants