[FIX] pos_sale_order_print: the print selector popup does not appear …#1564
Open
MarianoMartinezGC wants to merge 1 commit into
Open
[FIX] pos_sale_order_print: the print selector popup does not appear …#1564MarianoMartinezGC wants to merge 1 commit into
MarianoMartinezGC wants to merge 1 commit into
Conversation
…when only one is selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When printing a sale order from the POS Sale Order Management screen, the
SelectionPopup("What do you want to print?") is always displayed whenever atleast one print report is configured in the POS settings
(
print_sales_order_ids), including the degenerate case of a single configuredThis forces the cashier to perform a redundant click to select the only
available option on every print, which slows down checkout and is error-prone
in high-volume stores.
Current behavior before PR
In
SaleOrderManagementScreen._printSaleOrder, the popup is shown wheneverprint_sales_order_ids.length > 0. With a single configured report the cashierstill has to open the popup and pick the only item in the list before the report
is generated.
Desired behavior after PR is merged
executed directly via
do_action, reusing the existing error handling.popup is shown so the cashier can choose.
shown.
How to reproduce (runboat)
pos_sale_order_print.and print it.
After: the report is generated directly, with no popup.
shown.
FL-556-7059