Skip to content

patch ocrd_page_generateds for automatic inheritance#700

Open
bertsky wants to merge 2 commits into
OCR-D:masterfrom
bertsky:ocrd-page-patch-inheritance
Open

patch ocrd_page_generateds for automatic inheritance#700
bertsky wants to merge 2 commits into
OCR-D:masterfrom
bertsky:ocrd-page-patch-inheritance

Conversation

@bertsky

@bertsky bertsky commented Jun 30, 2021

Copy link
Copy Markdown
Collaborator

Fix #698

@bertsky bertsky requested a review from kba June 30, 2021 17:02
@bertsky bertsky force-pushed the ocrd-page-patch-inheritance branch from f88421e to ba88aee Compare June 30, 2021 22:59

@kba kba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and patch applies fine. Proper support for inheritance of TextStyles will make life easier for e.g. the font recognition project. Any reason not to include in the next release together with #744 and #753?

@bertsky

bertsky commented Dec 6, 2021

Copy link
Copy Markdown
Collaborator Author

Any reason not to include in the next release together with #744 and #753?

Just to differentiate purely technical changes (the other PRs) from functional ones / new behaviour such as this. But release as you see fit.

This was referenced Dec 7, 2021
@kba

kba commented Dec 21, 2021

Copy link
Copy Markdown
Member

further discussion in bertsky#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OcrdPage: propagate inherited attributes and TextStyle

3 participants