Do not store std::string in PETSc-allocated structs#61
Merged
Conversation
pelesh
approved these changes
May 28, 2026
pelesh
left a comment
Collaborator
There was a problem hiding this comment.
Tests on Frontier pass, changes look good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
This changes the storage of strings in structs that are allocated with
PetscCallocfromstd::stringtochar[32]. This essentially reverts a prior attempt to "modernize" the storage of strings, which comes with a few concerns. The application-level strings remainstd::string, and they are converted tochar[]for storage in the structs.After Frontier's recent OS upgrade, several tests were failing due to an obscure segmentation fault.
The outstanding stack issue I recall seeing with Valgrind was the
std::stringvalues stored in the structs, where the appropriate destructors were not being called. The changes in this PR resolve the failing tests and the Valgrind errors.We can revisit storing
std::stringin the structs if we also update the object allocation (e.g., withnew) and deallocation. The memory would no longer be owned by PETSc.Relates to this issue.