Skip to content

fix(config): report gateway reload failures#186

Open
MicroMilo wants to merge 1 commit into
OpenBMB:mainfrom
MicroMilo:codex/report-gateway-reload-failures
Open

fix(config): report gateway reload failures#186
MicroMilo wants to merge 1 commit into
OpenBMB:mainfrom
MicroMilo:codex/report-gateway-reload-failures

Conversation

@MicroMilo

Copy link
Copy Markdown

Summary

  • await gateway reload notifications on config save and manual reload
  • include structured gateway reload status in the config API response
  • show a frontend error when disk save succeeds but gateway reload fails

Verification

  • npm exec -- tsc --noEmit -p tsconfig.json
  • npm --workspace ui run build

Notes

This is a real UI/runtime observability bug: the previous API swallowed gateway reload failures and the frontend always reported a successful reload.

@MicroMilo

Copy link
Copy Markdown
Author

Validation note:

This PR fixes a feedback-chain bug in the config reload workflow.

Before this change, the config save/reload route notified the gateway reload path without surfacing reload failures back to the API response. As a result, the frontend displayed a successful save/reload state even when the gateway reload operation failed and the active runtime could still be using the previous config.

This PR changes the workflow in two important ways:

  • the server awaits the gateway reload notification and includes a structured reload.gateway result in the API response;
  • the frontend distinguishes "config saved" from "gateway reload failed" and surfaces the reload failure to the user.

Validation commands currently listed by this PR:

npm exec -- tsc --noEmit -p tsconfig.json
npm --workspace ui run build

The implementation direction is correct, but the self-validation is still incomplete. A focused regression test should stub getPilotDeckGateway().reloadConfig() to throw and assert that:

  • PUT /api/config still returns a config response;
  • the response contains reload.gateway.error;
  • the frontend hook shows an error instead of the success message.

That test would prove the fixed failure path, not only the type/build correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant