fix(config): report gateway reload failures#186
Conversation
|
Validation note: This PR fixes a feedback-chain bug in the config reload workflow. Before this change, the config save/reload route notified the gateway reload path without surfacing reload failures back to the API response. As a result, the frontend displayed a successful save/reload state even when the gateway reload operation failed and the active runtime could still be using the previous config. This PR changes the workflow in two important ways:
Validation commands currently listed by this PR: npm exec -- tsc --noEmit -p tsconfig.json
npm --workspace ui run buildThe implementation direction is correct, but the self-validation is still incomplete. A focused regression test should stub getPilotDeckGateway().reloadConfig() to throw and assert that:
That test would prove the fixed failure path, not only the type/build correctness. |
Summary
Verification
Notes
This is a real UI/runtime observability bug: the previous API swallowed gateway reload failures and the frontend always reported a successful reload.