Adding accessibility section for "Learn" page and menu.#1019
Conversation
jsjiang
left a comment
There was a problem hiding this comment.
Looks good! Thank you Scott for providing a quick solution.
Jing
|
One quick comment because I'm off VPN and can't see dev - the policy itself needs to be hyperlinked. Sorry if this already is, just couldn't tell from the screenshot. |
|
hi @adambuttrick The menu for Learn has a submenu item called "Accessibility" (a hyperlink). I think this might be what you're talking about or should there be something in the footer or somewhere else, also? |
There was a problem hiding this comment.
Pull request overview
Adds an “Accessibility” section to the Learn page accordion and exposes it via the Learn dropdown menu, supporting Issue #1018 (UC-mandated accessibility statement).
Changes:
- Add a new “Accessibility” accordion section on
/learnthat includesinfo/learnsub_accessibility.html. - Add “Accessibility” as a new Learn submenu item pointing to
#05. - Mirror the menu update in the
dev/header include.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
templates/learn.html |
Adds a new accordion section for Accessibility that pulls content from the external info-pages templates. |
templates/includes/top.html |
Adds an “Accessibility” link in the Learn dropdown menu (#05). |
dev/includes/header.html |
Keeps the dev header’s Learn menu in sync by adding the same link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Ok, @jsjiang and @adambuttrick changed to be sure link is in text (other repo, already merged) and link from footer to the |
Most of the change is actually in the info-pages repo. But to make it parallel with the other sections (heading, menu) I have to change things in here, also.
See #1018 .
I think CDLUC3/ezid-info-pages#3 has to be merged first and then this one merged and then we can test by deploying to development server.
I tested the changes locally (I have two different repos inside my code) and it looks ok to me.