fix(whats-new): re-bump to 26.12.1 so the corrected note shows#6
Merged
Conversation
The What's-new dialog only shows release entries NEWER than the user's stored lastSeenReleaseVersion, and requires an entry whose version === APP_VERSION (src/lib/release-notes.ts). #5 corrected the 26.12.0 copy in place without a version bump, so every user who had already dismissed the 26.12.0 dialog (lastSeen === current) — and first-run users, who never see the dialog at all — never received the correction. Move the corrected entry to 26.12.1 and bump package.json to match. Verified: getUnseenReleaseNotes('26.12.0','26.12.1',NOTES) => ['26.12.1']. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying jank with
|
| Latest commit: |
b79a253
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd7d1982.jank-4ii.pages.dev |
| Branch Preview URL: | https://fix-whats-new-26-12-1-rebump.jank-4ii.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4 / #5. The corrected v26.12.0 copy (#5) never reached users because of how the What's-new dialog gates display.
Why the in-place fix reached nobody (
src/lib/release-notes.ts):lastSeenReleaseVersion, and returns empty whenlastSeen === current.version === APP_VERSION(fail-silent otherwise).lastSeen === null) see nothing and just getlastSeenstamped tocurrent.So everyone who already dismissed the
26.12.0dialog (lastSeen === current === 26.12.0) — the only people the dialog ever targets — got nothing.Fix: move the corrected entry to
26.12.1and bumppackage.jsonto match. Users atlastSeen = 26.12.0now get the corrected26.12.1dialog.Verified against the real code:
vitest src/lib/release-notes.spec.tsgreen (6/6),tsc -bclean.🤖 Generated with Claude Code