feat(mute): collapse muted-thread embeds with reveal (parity with muted users)#8
Merged
Merged
Conversation
…sers
Thread mute only hard-hid notes in feeds/notifications. Muted USERS get a
second tier: a 'show anyway' placeholder (<MutedNote>) wherever a note
renders through <Note> but isn't list-filtered (embeds/quotes and direct
detail views). Thread mute lacked that tier, so a quote of a muted thread
rendered in full.
Bring thread mute to parity at every tier muted users use:
- Note/index.tsx: collapse to <MutedNote reason='thread'> with a
'Temporarily display this note' reveal (embeds + detail)
- NoteCard.shouldHide + useFilteredReplies (both hooks): hard-hide
muted-thread notes (standalone cards + thread reply lists)
- MutedNote generalized with a reason prop ('user' default) so the
component is not duplicated
Feeds + notifications stay hard-hide, same as muted users.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying jank with
|
| Latest commit: |
6af469d
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this exists
Follow-up to #7 (thread muting, v26.12.2). This commit was developed and approved alongside #7 but landed on the branch after #7 was rebase-merged, so it didn't make it into
main. This PR restores it.What it does
Thread muting hard-hid notes in feeds/notifications, but didn't replicate the second tier that muted users get: a collapse-with-reveal placeholder wherever a note still renders through
<Note>but isn't list-filtered (quotes/embeds and direct detail views). So a note that quoted a muted thread rendered the muted content in full.This brings thread mute to parity with user mute at every tier:
Note/index.tsx— collapse to<MutedNote reason="thread">("This note is from a thread you muted" + "Temporarily display this note") for embeds + detail.NoteCard.shouldHide+useFilteredReplies(both hooks) — hard-hide muted-thread notes for standalone cards and thread reply lists.MutedNotegeneralized with areasonprop ('user'default) so the two share one component.Feeds + notifications stay hard-hide — same as muted users. No version bump: this is a consistency refinement of the already-announced v26.12.2 feature (ships via the reload banner, no separate "What's new").
Test plan
npm run buildclean, 855 tests pass, lint clean.🤖 Generated with Claude Code