fix: reveal whole muted thread (note + replies) in one click#10
Merged
Conversation
Deploying jank with
|
| Latest commit: |
9720017
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46522317.jank-4ii.pages.dev |
| Branch Preview URL: | https://fix-muted-thread-reveal.jank-4ii.pages.dev |
Opening a muted thread showed the note but hid every reply: the reveal was note-scoped (showMuted on each Note), so clicking reveal un-collapsed only the root while useFilteredReplies kept hard-hiding the replies. Make the reveal thread-scoped AND per-column via MutedThreadRevealProvider (mounted once per <Column>). The Note collapse and the reply filters (useFilteredReplies + useFilteredAllReplies) both read it, keyed by thread root, so one click on 'Reveal muted thread' shows the note and all its replies together. Being per-column, closing the thread's detail column drops the reveal: reopening starts collapsed again, so a still-muted thread never looks unmuted (reveal = temporary peek, unmute = permanent). Also fixes a parity-commit inconsistency where useFilteredAllReplies carried muteEventIdSet as an unused dep but never applied the hide. Threads stay muted in feeds/notifications regardless. Thread button copy: 'Temporarily display this note' -> 'Reveal muted thread'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d1edda4 to
9720017
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening a muted thread and clicking reveal showed the note but none of its replies — you couldn't read the conversation. This makes the reveal cover the whole thread, scoped per-column so it behaves like a temporary peek (distinct from unmute).
Root cause: the reveal was note-scoped —
showMutedlived on eachNote, so revealing the root un-collapsed only that one note, whileuseFilteredReplieskept hard-hiding the replies (and each reply renders throughContent, notNote, so it had no reveal of its own).Fix: make the reveal thread-scoped and per-column via
MutedThreadRevealProvider, mounted once inside every<Column>.Notemuted-thread collapse and both reply filters (useFilteredReplies+useFilteredAllReplies) read the same per-column reveal set, keyed bygetThreadRootId.Also fixes a parity-commit inconsistency where
useFilteredAllRepliescarriedmuteEventIdSetas an unused dependency but never applied the hide — both reply hooks now behave identically.Threads stay muted in feeds and notifications regardless. Thread button copy: "Temporarily display this note" → "Reveal muted thread".
Ships as v26.13.1.
Test plan
npm run buildclean, 857 tests pass, lint clean.🤖 Generated with Claude Code