Remove column pin/unpin (opened columns are always ephemeral)#20
Merged
Conversation
Clicking a note/profile/hashtag/relay still opens a transient peek column, but it can no longer be promoted to permanent. The deck is built only via the AddColumnModal, matching the mobile push/pop model. The transient lifecycle (spawn, back-to-close, replace/append) is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…bel command Pin/unpin is gone, so "unpinned" no longer names anything. Rename the bulk-close helper plus its palette command, and relabel it to "Close all temporary columns" (new en.ts key; dead pin keys kept per the append-only i18n rule). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…umns Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying jank with
|
| Latest commit: |
86f3f3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b5ed992.jank-4ii.pages.dev |
| Branch Preview URL: | https://worktree-remove-column-pin-s.jank-4ii.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the column-level pin/unpin controls. Clicking a note / profile / hashtag / relay still opens a transient "peek" column, but it can no longer be promoted to permanent. The deck is built only through the Add Column modal. This brings desktop in line with the mobile push/pop model (v26.15.0), where opened views are already ephemeral.
transientlifecycle itself (spawn-on-click, back-to-close, replace/append modes, sync exclusion) is unchanged. Only the pin/unpin affordances are removed: the header buttons, thepinColumn/unpinColumnprovider methods, and the two command-palette commands.closeAllUnpinnedtocloseAllTransientand relabels its palette command to "Close all temporary columns" (newen.tskey; the deadPin column/Unpin column/Close all unpinned columnskeys are kept per the append-only i18n rule).Not touched: the note-pin feature (kind 10001) and Favorites / "Pinned Users" (kind 10010). Separate systems that happen to share the word "pin".
No data migration: columns a user previously pinned are already stored as normal
transient: falsecolumns and keep loading as permanent columns.Commits
feat(deck): remove column pin/unpin so opened views are always ephemeralrefactor(deck): rename closeAllUnpinned to closeAllTransient and relabel commandchore(release): v26.15.3 release noteTest plan
npm run build(tsc -b && vite build) greennpm testgreen (898 passed, 1 skipped)pinColumn/unpinColumn/onPin/onUnpin/closeAllUnpinned; note-pin + Favorites untouched⋯ · ✕in the header; reload clears it;+-added columns persist; Cmd-K palette shows "Close all temporary columns" and no Pin/Unpin; note-pin and Favorites still work🤖 Generated with Claude Code