Update CLAUDE.md paths for ohadey#2
Conversation
…claude/pull-latest-changes-jY0r5
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Claude-executor instructions to use ohadey’s Mac filesystem layout, and adds a scratch GLP file containing proposed “unfriend” feature changes for a typed social agent.
Changes:
- Update
CLAUDE.mdto replace Mac paths with/Users/ohadey/Desktop/Grassroots/GLP2/GLP/.... - Add
programs/temp.glpcontaining proposed type/logic additions for an “unfriend” flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
CLAUDE.md |
Repoints Mac-specific commands/paths to the new local checkout location. |
programs/temp.glp |
Adds a temporary/proposal GLP snippet for unfriend support (types + agent clauses + output removal helper). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| %% temp.glp - Typed social agent (cssg) with unfriend support | ||
| %% | ||
| %% Based on typed_book/cssg/typed_social_agent.glp |
There was a problem hiding this comment.
The header says this is for typed_social_agent.glp, but the repo has multiple similarly-named programs (e.g. programs/typed_book/social_graph/typed_social_agent.glp and programs/typed_book/cssg/typed_social_agent.glp) with different message/key types. Please clarify the intended target path in the comment/header to avoid applying these additions to the wrong variant.
| %% temp.glp - Typed social agent (cssg) with unfriend support | |
| %% | |
| %% Based on typed_book/cssg/typed_social_agent.glp | |
| %% temp.glp - Extensions for cssg typed_social_agent with unfriend support | |
| %% | |
| %% Target program: programs/typed_book/cssg/typed_social_agent.glp |
| %% temp.glp - Typed social agent (cssg) with unfriend support | ||
| %% | ||
| %% Based on typed_book/cssg/typed_social_agent.glp | ||
| %% Added: unfriend(Constant) in UserContent, FriendContent, AgentContent | ||
| %% remove_output helper, user-initiated and network-received unfriend clauses |
There was a problem hiding this comment.
programs/temp.glp is not loadable as a standalone GLP program: it references undeclared types/procedures in this file (e.g., Decision, PendingValue, OutputsList, lookup_send/4, and agent/4 is only partial). If this is intended as a patch note/scratchpad, it would be better placed under docs/handovers (or removed from the repo) rather than living in programs/ where files are expected to be runnable.
| ; approve_child_intro(Constant, Constant, PendingValue) | ||
| ; response(Response) | ||
| ; unfriend(Constant). | ||
|
|
||
| %% Content carried inside agent-to-user messages (msg(agent, '_user', Content)) | ||
| AgentContent ::= befriend(Constant, Response) |
There was a problem hiding this comment.
remove_output/3 currently only matches and removes an entry when the output stream is already [] (output(K, [])). In the unfriend flow this means the friend output will usually not be removed/closed, so the unfriend operation won’t actually disconnect the friend. Consider matching output(K, Out) for the key, explicitly closing the stream by unifying it to [], and then removing the entry from the outputs list.
…claude/pull-latest-changes-jY0r5
- typed_social_agent.glp: Add OutputKey type, unfriend in UserContent/AgentContent/FriendContent, remove_output/3, user and network unfriend clauses, update lookup_send/add_output to use friend(Name) keys - project_actors.glp: Extended actor scripts with unfriend scenario (Alice unfriends Bob, Bob gets notification, Bob's post-unfriend send silently dropped) - project_dglp_boot.glp: dGLP boot file for unfriend scenario All 317 REPL tests pass. All files type-check successfully. https://claude.ai/code/session_01CDmrikvoisBLdJqgBnETZB
…claude/pull-latest-changes-jY0r5
Update Mac paths to /Users/ohadey/Desktop/Grassroots/GLP2/GLP and add temp.glp with unfriend code