Skip to content

Added _sparse_orthogonal_conditional#2027

Draft
sc336 wants to merge 29 commits into
developfrom
sc336/dgp_components
Draft

Added _sparse_orthogonal_conditional#2027
sc336 wants to merge 29 commits into
developfrom
sc336/dgp_components

Conversation

@sc336

@sc336 sc336 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Draft PR for taking the GPflow components from this GPflux PR into GPflow. The work is based on this paper.

============================

PR type: bugfix / enhancement / new feature / doc improvement

Related issue(s)/PRs:

Summary

Proposed changes

  • ...
  • ...
  • ...

What alternatives have you considered?

Minimal working example

# Put your example code in here

Release notes

Fully backwards compatible: yes / no

If not, why is it worth breaking backwards compatibility:

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black+isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

@codecov

codecov Bot commented Dec 6, 2022

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 31.73653% with 228 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (cce56f8) to head (4d56f14).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
gpflow/conditionals/util.py 6.12% 92 Missing ⚠️
gpflow/posteriors.py 30.90% 76 Missing ⚠️
gpflow/covariances/multioutput/cvvs.py 45.45% 24 Missing ⚠️
gpflow/covariances/cvfs.py 42.85% 12 Missing ⚠️
gpflow/covariances/cvvs.py 42.10% 11 Missing ⚠️
gpflow/covariances/multioutput/cvfs.py 68.75% 10 Missing ⚠️
gpflow/conditionals/conditionals.py 40.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cce56f8) and HEAD (4d56f14). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (cce56f8) HEAD (4d56f14)
10 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2027       +/-   ##
============================================
- Coverage    98.09%   47.49%   -50.61%     
============================================
  Files           93      100        +7     
  Lines         5263     5729      +466     
============================================
- Hits          5163     2721     -2442     
- Misses         100     3008     +2908     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant