Implement faster predict_y and generalised it to GPMC#2089
Draft
zhixiaozhu wants to merge 8 commits into
Draft
Conversation
a0e11e3 to
2b44982
Compare
0dc06f7 to
71f8414
Compare
Author
|
Hi @uri-granta, @jesnie, I was trying to put together this PR but the CI kept failing. Could you please kindly help me to have a look if this was an issue by my change or the dev branch? I tired to run CI on the dev branch and it seemed to have failed with the same error. Many thanks. |
Member
|
Sorry I missed your comment! There were some typing issues exposed by third party library updates that have now been fixed (see #2094). Hopefully merging the latest develop will fix your problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type: bugfix / enhancement / new feature / doc improvement
Related issue(s)/PRs:
Summary
Proposed changes
What alternatives have you considered?
Minimal working example
# Put your example code in hereRelease notes
Fully backwards compatible: yes / no
If not, why is it worth breaking backwards compatibility:
PR checklist
make format)make check-all)