Skip to content

Fix typo in SGPR_notes.md#2112

Open
berghdavid wants to merge 2 commits into
GPflow:developfrom
berghdavid:patch-1
Open

Fix typo in SGPR_notes.md#2112
berghdavid wants to merge 2 commits into
GPflow:developfrom
berghdavid:patch-1

Conversation

@berghdavid

@berghdavid berghdavid commented May 22, 2024

Copy link
Copy Markdown

PR type: doc improvement

Related issue(s)/PRs:

Summary

Proposed changes

A minor error was corrected. Expanding

$\frac{1}{2} \mathbf{y}^\top [ \mathbf{Q}_{ff} + \sigma^2 \mathbf{I} ]^{-1} \mathbf{y}$

yields

$\frac{1}{2} \sigma^{-2} \mathbf{y}^\top ( \mathbf{I} - \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A} ) \mathbf{y}$,
not
$\tfrac{1}{2}\sigma^{-2}\mathbf y^\top (\mathbf I - \sigma^{-2} \mathbf A^{\top} \mathbf B^{-1}\mathbf A)\mathbf y$.

I believe the extra $\sigma^{-2}$ was accidentally left in when simplifying
$\frac{1}{2} \mathbf{y}^\top (\sigma^{-2} \mathbf{I} - \sigma^{-2} \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A}) \mathbf{y}$
as
$\frac{1}{2} \sigma^{-2} \mathbf{y}^\top ( \mathbf{I} - \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A} ) \mathbf{y}$.

The equation that follows this line is expanded to the correct definition $\tfrac{1}{2}\sigma^{-2}\mathbf y^\top\mathbf A^{\top} \mathbf B^{-1}\mathbf A\mathbf y$. No other changes are therefore required.

What alternatives have you considered?

Minimal working example

# Put your example code in here

Release notes

Fully backwards compatible: yes

If not, why is it worth breaking backwards compatibility:

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black+isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

A minor error was corrected. Expanding

\frac{1}{2} \mathbf{y}^\top [ \mathbf{Q}_{ff} + \sigma \mathbf{I} ]^{-1} \mathbf{y}

yields

\frac{1}{2} \sigma^{-2} \mathbf{y}^\top ( \mathbf{I} - \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A} ) \mathbf{y}.
@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.36%. Comparing base (f09a686) to head (22bf0ba).
⚠️ Report is 2 commits behind head on develop.

❌ Your project check has failed because the head coverage (48.36%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f09a686) and HEAD (22bf0ba). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (f09a686) HEAD (22bf0ba)
7 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2112       +/-   ##
============================================
- Coverage    98.19%   48.36%   -49.84%     
============================================
  Files           98       98               
  Lines         5499     5489       -10     
============================================
- Hits          5400     2655     -2745     
- Misses          99     2834     +2735     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant