Fix typo in SGPR_notes.md#2112
Open
berghdavid wants to merge 2 commits into
Open
Conversation
A minor error was corrected. Expanding
\frac{1}{2} \mathbf{y}^\top [ \mathbf{Q}_{ff} + \sigma \mathbf{I} ]^{-1} \mathbf{y}
yields
\frac{1}{2} \sigma^{-2} \mathbf{y}^\top ( \mathbf{I} - \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A} ) \mathbf{y}.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (48.36%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #2112 +/- ##
============================================
- Coverage 98.19% 48.36% -49.84%
============================================
Files 98 98
Lines 5499 5489 -10
============================================
- Hits 5400 2655 -2745
- Misses 99 2834 +2735 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type: doc improvement
Related issue(s)/PRs:
Summary
Proposed changes
A minor error was corrected. Expanding
yields
not
I believe the extra$\sigma^{-2}$ was accidentally left in when simplifying
$\frac{1}{2} \mathbf{y}^\top (\sigma^{-2} \mathbf{I} - \sigma^{-2} \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A}) \mathbf{y}$
$\frac{1}{2} \sigma^{-2} \mathbf{y}^\top ( \mathbf{I} - \mathbf{A}^\top \mathbf{B}^{-1} \mathbf{A} ) \mathbf{y}$ .
as
The equation that follows this line is expanded to the correct definition$\tfrac{1}{2}\sigma^{-2}\mathbf y^\top\mathbf A^{\top} \mathbf B^{-1}\mathbf A\mathbf y$ . No other changes are therefore required.
What alternatives have you considered?
Minimal working example
# Put your example code in hereRelease notes
Fully backwards compatible: yes
If not, why is it worth breaking backwards compatibility:
PR checklist
make format)make check-all)