Skip to content

[codex] Sync student-facing Notebook 4 (D-Wave)#11

Merged
bernalde merged 2 commits into
mainfrom
codex/sync-notebook4-dwave
May 7, 2026
Merged

[codex] Sync student-facing Notebook 4 (D-Wave)#11
bernalde merged 2 commits into
mainfrom
codex/sync-notebook4-dwave

Conversation

@bernalde

@bernalde bernalde commented Apr 11, 2026

Copy link
Copy Markdown
Member

Closes #8.

Summary

This PR aligns the Python and Julia Notebook 4 materials at the student-facing level without changing the executable notebook logic.

What Changed

  • aligned the Notebook 4 section flow around the problem statement, example, quantum annealing section, and references
  • added Python-side environment and execution notes near the setup/import area
  • added explicit Python-side D-Wave account guidance around dwave setup, dwave ping, and DWaveSampler()
  • synchronized the QUBO notation in the problem statement and matrix-definition walkthrough
  • updated the Julia Notebook 4 metadata version so it matches the committed Julia environment
  • added a Notebook 4 pair-sync test module that checks headings, setup guidance, references, notation, and Julia metadata

Validation

  • /home/bernalde/repos/QuIP/.venv/bin/python -m unittest tests.test_notebook4_pair_sync
  • /home/bernalde/repos/QuIP/.venv/bin/python -m unittest discover -s tests
  • ~/.local/bin/uv run --group docs python -m unittest discover -s tests

@review-notebook-app

review-notebook-app Bot commented Apr 11, 2026

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

bernalde
bernalde commented Apr 17, 2026
View reviewed changes
Comment thread notebooks_jl/4-DWave.ipynb
Comment thread notebooks_jl/4-DWave.ipynb
Comment thread notebooks_py/4-DWAVE_python.ipynb
bernalde
bernalde commented May 7, 2026
View reviewed changes

@bernalde bernalde left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one blocking issue: the Python notebook text and the new sync test moved the QUBO offset notation to beta, but the executable Python cells still use cQ. That leaves the student-facing notation unsynchronized and the test suite does not catch it. I also left one nonblocking note on local D-Wave setup guidance. I would not merge this until the blocking issue is addressed. GitHub would not allow this account to submit REQUEST_CHANGES because it is the PR author, so this review is submitted as COMMENT.

Comment thread tests/test_notebook4_pair_sync.py
Comment thread notebooks_py/4-DWAVE_python.ipynb Outdated
@bernalde

bernalde commented May 7, 2026

Copy link
Copy Markdown
Member Author

Not addressed: the top-level ReviewNB bot comment is informational and does not request a code or documentation change. The actionable inline review comments were addressed in 7a6a046.

@bernalde bernalde marked this pull request as ready for review May 7, 2026 23:11
@bernalde bernalde merged commit cbd05fb into main May 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sync Python and Julia student-facing content for Notebook 4 (D-Wave)

1 participant

@bernalde