Fix Colab Julia 1.12 GAMA resolve fallback#15
Merged
Conversation
bernalde
commented
May 20, 2026
bernalde
left a comment
Member
Author
There was a problem hiding this comment.
Review summary:
- Blocking issues: none.
- Nonblocking issues: none.
- Questions: none.
- Tests run and outcomes:
python -m unittest tests.test_verify_notebookspassed, 20 tests.python -m py_compile scripts/verify_colab_runtime_smokes.pypassed.UV_CACHE_DIR=.uv-cache uv run --group docs python -m unittest discover -s testspassed, 64 tests.make verify-julia-colab-mismatch-smokepassed under Julia 1.12.6; it exercised the mismatch policy, resolve fallback, and temporary instantiate smoke for1-MathProg,2-QUBO,3-GAMA,4-DWave, and5-Benchmarking.git diff --check origin/main...HEADpassed.gh pr checks 15 --watch --fail-fastpassed forbuildandjulia-notebook-smokes;deploywas skipped as expected for a PR.
- Merge as-is: yes. The fallback is gated to Colab manifest/runtime mismatches, the automated smoke covers the stale manifest resolver cases across all Julia notebook envs, and the PR is clean/mergeable.
Review disposition note: I attempted to submit this as APPROVE, but GitHub rejected the review because the authenticated account is the PR author, so this is submitted as COMMENT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pkg.resolve()cannot move stale notebook manifests off Julia-1.12-incompatibleHDF5_jll 1.14.2pins.Pkg.resolve()path, but falls back toPkg.update()only for Colab manifest/runtime mismatches when resolve fails.1-MathProg,2-QUBO,3-GAMA,4-DWave, and5-Benchmarking.Tests run:
python -m unittest tests.test_verify_notebooks- passed, 20 tests.python -m py_compile scripts/verify_colab_runtime_smokes.py- passed./home/bernalde/.julia/juliaup/julia-1.12.6+0.x64.linux.gnu/bin/julia --project=./scripts -e 'include("scripts/notebook_bootstrap.jl"); using .QuIPNotebookBootstrap; println(QuIPNotebookBootstrap.detect_colab())'- passed.make verify-julia-colab-mismatch-smoke- passed under Julia 1.12.6; reproduced stale manifest resolver conflicts, used the fallback update, and printedJulia Colab project instantiate smoke okfor1-MathProg,2-QUBO,3-GAMA,4-DWave, and5-Benchmarking.notebooks_jl/envs/3-GAMA- passed and printed3-GAMA Julia 1.12 import smoke ok.--depwarn=errorinstantiate smoke with a temporary copy ofnotebooks_jl/envs/3-GAMA- passed and printeddepwarn instantiate smoke ok.UV_CACHE_DIR=.uv-cache uv run --group docs python -m unittest discover -s tests- passed, 64 tests.make verify-julia-colab-smokes COLAB_JULIA_SMOKE_NOTEBOOKS=5-Benchmarking- passed.make verify-julia-notebook5-cache-smoke- passed.git diff --check- passed.Notes: