Bugfixes in STAGE mercury bidirectional flux calculations#261
Open
tnskipper wants to merge 1 commit into
Open
Conversation
- add exponent to parameters - multiply by concentration to make value actually a flux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contact:
Nash Skipper, U.S. Environmental Protection Agency
Type of code change:
Bug fix
Description of changes:
CMAS Center Forum user yanzcj identified two bugs in the STAGE calculation of mercury bidirectional flux here:
https://forum.cmascenter.org/t/possible-issues-with-mercury-bidirectional-exchange-under-stage-in-cmaq-v5-5/6184
One issue is that the value of the variable
flux_hgIIinCCTM/src/depv/stage/STAGE_MOD.Fdoes not multiply the deposition velocity by the concentration and is therefore not a flux in units ppm * m/s but is a deposition velocity in units of m/s.Original code:
Updated code:
The second issue is that exponents are left off of the following parameters in
CCTM/src/depv/stage/HGSIM.F:These should be:
Thank you to user yanzcj for pointing out these issues.
Issue:
No github issue, but the issue was originally raised on the CMAS Center Forum:
https://forum.cmascenter.org/t/possible-issues-with-mercury-bidirectional-exchange-under-stage-in-cmaq-v5-5/6184
Summary of Impact:
Mercury bidirectional flux is not activated by default, so most users will see no difference in results. For the case with mercury bidirectional flux activated, impacts are summarized below.
A one year simulation for the northern hemisphere for 2022 (with 1 month of spinup in December 2021) using the cb6r5m_ae7_aq chemical mechanism with mercury bidirectional flux activated (
setenv CTM_HGBIDI Yin runscript) was conducted using the original and updated code to test the impacts of the change. Results below show the percent change ((updated code - original code) / original code) for the annual averages ofHGandHGIIGASconcentrations in the average concentration output file (ACONC) for the surface layer. Also shown are the percent changes in annual average dry deposition values forHGandHGIIGASand the annual average percent change in theHG_Emisdiagnostic value from the dry deposition output file (DRYDEP). The differences in the annual averages are small.ACONC results
DRYDEP results
Tests conducted:
The updated code was run for a 1 day benchmark test using both standard and debug compiler flags for the following compilers:
In addition to the benchmark tests, a one year simulation for the northern hemisphere for 2022 (with 1 month of spinup in December 2021) was conducted using the original and updated code to test the impacts of the change. See summary of impact section above for these results.