Validate phone number before starting login auth#1
Open
UrfanSarkarov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isPhoneNumberValid()inLoginFragmentthat useslibphonenumberto parse and validate the entered number.start_phone_number_authcall inonNextClickwhen the number is invalid and show a localized toast using a newinvalid_phone_numberstring resource.invalid_phone_numberentry toHouseclub/src/main/res/values/strings.xml.Testing
./gradlew :Houseclub:assembleDebugwhich failed in this environment because the Gradle wrapper script is not present. (failure)gradle :Houseclub:assembleDebugwhich failed withUnsupported class file major version 69due to a toolchain mismatch in the execution environment. (failure)Codex Task