Skip to content

ghub-request: support ghub-json-{object-type}#172

Closed
kiennq wants to merge 1 commit into
magit:mainfrom
kiennq:fix/json-customize
Closed

ghub-request: support ghub-json-{object-type}#172
kiennq wants to merge 1 commit into
magit:mainfrom
kiennq:fix/json-customize

Conversation

@kiennq

@kiennq kiennq commented May 1, 2025

Copy link
Copy Markdown
Contributor

Trying to get back the output type customization here as one of my packages relied on the output for json be plist and array instead of alist.

@tarsius

tarsius commented May 5, 2025

Copy link
Copy Markdown
Member

I decided to remove these variables (instead of fixing them as you do in this pr) because removing them by definition removes the risk that some sets them globally, and because I figured those who want to use different types can just use the :reader argument.

I've now made it slightly easier to use that argument and added an example in 290482c.

@tarsius tarsius closed this in 290482c May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants