Update document.go#97
Open
sergioangulo wants to merge 1 commit into
Open
Conversation
https://tip.golang.org/doc/go1.12#cgo (...)Mangled C names are no longer accepted in packages that use Cgo(...)
|
Es un error de esta api. Debes cambiar esa linea de ese archivo que te marca error por la siguiente: nodePtr.doc = (*C.xmlDoc)(document.DocPtr()) |
|
when this pr will be merged? Currently is not possible to use this library with new version of go |
|
I need this too @jbowtie could you please merge it? |
1 similar comment
|
I need this too @jbowtie could you please merge it? |
Contributor
|
It's been merged in my fork for some time; I don't have commit rights on the moovweb version. |
kyuden
added a commit
to WOVNio/gokogiri
that referenced
this pull request
Jan 30, 2020
|
Can we please merge this PR as I'm also getting this same error. I also tried to fork this repo and fix it in my repo but still I'm getting this error? any workaround or solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tip.golang.org/doc/go1.12#cgo
(...)Mangled C names are no longer accepted in packages that use Cgo(...)