A bunch of fixes for export nodes#605
Draft
mishoo wants to merge 1 commit into
Draft
Conversation
`js2-visit-extern-binding` will now walk the bindings in proper
order (left-to-right) both for `import` and `export` parents. Previously,
the walker would descend into the right node first for `export`, with the
visible bug that `js2-node-at-point` would not find the `foo` name in this
case:
export { |foo as bar };
Other small fixes:
- do not extend the boundary of the `foo` name node in a case like this:
export default foo ;
- include the semicolon when printing nodes like the above
- fix a bunch of warnings related to length of docstrings; also type of a
defcustom.
- minor cleanups
Collaborator
|
Hi! Thanks for this. Could you add a few more tests? The |
Contributor
Author
Yep, that's why I marked it as draft, but I didn't get to it yet... hopefully this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js2-visit-extern-bindingwill now walk the bindings in proper order (left-to-right) both forimportandexportparents. Previously, the walker would descend into the right node first forexport, with the visible bug thatjs2-node-at-pointwould not find thefooname in this case:Other small fixes:
do not extend the boundary of the
fooname node in a case like this:include the semicolon when printing nodes like the above
fix a bunch of warnings related to length of docstrings; also type of a defcustom.
minor cleanups