crates/nh-installable/src/tests.rs (1)

1-363: ⚡ Quick win

Consider adding test coverage for NH_FILE resolution and error cases.

The test suite comprehensively covers flake-based environment variable resolution and precedence, but two areas lack coverage:

1. NH_FILE resolution: The code at lib.rs:318-326 handles NH_FILE (with optional NH_ATTRP), but no tests exercise this path.
2. Error cases: Malformed environment variables (e.g., NH_FLAKE without a reference part) should return errors (lib.rs:303-314, 332-343), but no tests verify this behavior.

Example test additions

#[test]
#[serial]
fn test_resolve_uses_nh_file() {
  let env_guard = EnvGuard::clear();
  env_guard.set("NH_FILE", "/path/to/config.nix");
  env_guard.set("NH_ATTRP", "system.config");

  let resolved = Installable::Unspecified
    .resolve(CommandContext::Os)
    .unwrap();
  match resolved {
    Installable::File { path, attribute } => {
      assert_eq!(path, PathBuf::from("/path/to/config.nix"));
      assert_eq!(attribute, vec!["system", "config"]);
    },
    _ => panic!("Expected File, got {resolved:?}"),
  }
}

#[test]
#[serial]
fn test_resolve_errors_on_malformed_nh_flake() {
  let env_guard = EnvGuard::clear();
  env_guard.set("NH_FLAKE", "`#missing-reference`");

  let result = Installable::Unspecified.resolve(CommandContext::Os);
  assert!(result.is_err());
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/nh-installable/src/tests.rs` around lines 1 - 363, Add tests
exercising NH_FILE and malformed-env error paths: create serial tests similar to
existing ones that use EnvGuard::clear() and env_guard.set to set NH_FILE and
NH_ATTRP and then call Installable::Unspecified.resolve(CommandContext::Os)
asserting it returns Installable::File with expected PathBuf and attribute
vector (split on '.'); and add tests that set malformed values (e.g.,
NH_FLAKE="`#missing-reference`" and NH_FILE="`#bad`") and assert
Installable::Unspecified.resolve(...) returns an Err; reference the existing
helpers and behavior around Installable::Unspecified.resolve, EnvGuard, and
attribute parsing to mirror the style of tests like
test_resolve_with_nested_attribute and
test_resolve_no_env_vars_returns_unspecified.