Implement Rope::is_instance()#11
Open
truchi wants to merge 1 commit into
Open
Conversation
noib3
reviewed
Jul 31, 2023
| /// memory locations (not instances). Importantly, two clones that | ||
| /// post-cloning are modified identically will *not* be instances | ||
| /// anymore, even though they will have equal contents. | ||
| /// |
Owner
There was a problem hiding this comment.
To be consistent w/ all the other public methods we should add an # Examples section to show in code how this works.
noib3
reviewed
Jul 31, 2023
| /// post-cloning are modified identically will *not* be instances | ||
| /// anymore, even though they will have equal contents. | ||
| /// | ||
| /// Runs in O(1) time. |
Owner
There was a problem hiding this comment.
This time complexity can be removed since none of the other methods mention theirs.
noib3
requested changes
Jul 31, 2023
noib3
left a comment
Owner
There was a problem hiding this comment.
Hey, sorry for the long wait. Lgtm apart from the 2 comments regarding the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Following up on #6 (long time no see 😄), here is
Rope::is_instance().Documentation taken from ropey's, test taken from ropey's.
What do you think about that?
Thanks