Merge two-pass parser into single pass with array-based output and specific error messages#2
Merged
Merged
Conversation
…ecific error messages
- Replace removeComments() + removeTrailingCommas() with a single processInput()
that handles comments and trailing commas in one iteration over the input
- The trailing-comma lookahead is now comment-aware: it skips // and /* */
regions when scanning forward for } or ], enabling correct handling of
patterns like {"a": 1, // comment\n}
- Switch string accumulation from $result .= $char to $result[] = $char with
a final implode(), avoiding O(n²) realloc behavior on large inputs
- Distinguish unclosed string vs unclosed block comment in error sentinels:
"unclosed string literal" vs "unclosed block comment"
- Remove isWhitespace() helper (inlined into processInput() lookahead)
All 100 existing tests pass.
https://claude.ai/code/session_01KABhJ1aojwpPmJ3fGhVxsZ
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
otar
added a commit
that referenced
this pull request
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that handles comments and trailing commas in one iteration over the input
regions when scanning forward for } or ], enabling correct handling of
patterns like {"a": 1, // comment\n}
a final implode(), avoiding O(n²) realloc behavior on large inputs
"unclosed string literal" vs "unclosed block comment"
All 100 existing tests pass.
https://claude.ai/code/session_01KABhJ1aojwpPmJ3fGhVxsZ