Skip to content

Improve device workflow#954

Open
hekhuisk wants to merge 5 commits into
oauthlib:masterfrom
hekhuisk:improve-device-workflow
Open

Improve device workflow#954
hekhuisk wants to merge 5 commits into
oauthlib:masterfrom
hekhuisk:improve-device-workflow

Conversation

@hekhuisk

Copy link
Copy Markdown

Note: This branches from #920 so commits 90d8aa8 and 68b292a are both from that PR and once that PR gets merged, this one will be touching less code.

Cleans up the existing device workflow to make it follow how the authorization code workflow works and the overall structure of the library.

  • Moves validation into the GrantType
  • Validates scopes which it is supposed to do, but was not doing
  • Adds validate_device_code to the request validator for callers to implement
  • Adds missing error handling required by the spec for authorization_pending, slow_down, expired_token, and access_denied.

Resolves #944
Resolves #949

I know the guidelines say one PR for one issue, but these issues are both very closely related and felt like a single chunk of work.

hekhuisk added 5 commits July 14, 2025 16:04
…AuthorizationCodeGrant, DeviceCodeGrant, RefreshTokenGrant, and ResourceOwnerPasswordCredentialsGrant.

Add some missing imports to the oauth2 __init__.py
…int does all of its work through the grant type handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant