Skip to content

Print timestep info to stdout instead of stderr#499

Merged
zcobell merged 2 commits into
adcirc:mainfrom
namo626:namo626/stdout
Apr 2, 2026
Merged

Print timestep info to stdout instead of stderr#499
zcobell merged 2 commits into
adcirc:mainfrom
namo626:namo626/stdout

Conversation

@namo626

@namo626 namo626 commented Mar 26, 2026

Copy link
Copy Markdown
Member

Description

Previously timestep information is printed to stdout (unit 6) but was changed to stderr (unit 0) in commit 33e290b . Was there a particular reason for this? This commit sets screenunit back to 6.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Bug fix with breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to existing feature to add new functionality
  • New feature (non-breaking change which adds functionality)
  • Breaking change (feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

How Has This Been Tested?

Relevant Publications (if applicable)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • My code is up-to-date and tested with changes from the latest version of main

If any of the above are not checked, please explain why:

Further comments

@zcobell zcobell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this. Can we instead use:

use iso_fortran_env, only: output_unit

then:

ScreenUnit = output_unit

This will continue to move us away from hard coded unit numbers.

Thanks! And apologies for the slow review.

@namo626

namo626 commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

Thank you for the suggestion! I've also updated the message description.

@zcobell zcobell merged commit a8ecc59 into adcirc:main Apr 2, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants