Fix tool_choice rejection in thinking-mode providers#3
Open
shagghiesuperstar wants to merge 1 commit into
Open
Fix tool_choice rejection in thinking-mode providers#3shagghiesuperstar wants to merge 1 commit into
shagghiesuperstar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some providers (DeepSeek V4, Qwen3 with thinking mode enabled) reject
tool_choicewith a 400 error because the thinking process conflicts with the forced tool choice parameter.Fix
build_nim_payload()that stripstool_choicefrom the payload when the model name contains "thinking" or whenPROVIDER_DISABLE_TOOL_CHOICE=trueis set in the environmentprovider_disable_tool_choice: bool = FalsetoSettingsinconfig.pyfor explicit overrideChanges
src/proxy/config.py— new settingprovider_disable_tool_choicesrc/proxy/translate.py— guard after oai_tools block omitstool_choicefor thinking-mode providers