Close pipe fd when owner process exits#215
Open
hlindset wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this issue while playing around with Vix streams: When halting a stream early, it seems like the target pipe
fdcan stay open until resource gc/cleanup.I've added a regression test, asserting
"Bad file descriptor"instead of:eagainafter the owner process exits. The fix makesfd_rt_stopcallclose_fdon the NIF resourcefd. I noticed there was an earlier commit 422fcfe aiming to fix a race condition, whereclose_fdwas moved out offd_rt_stop. Could that have been because theclose_fdinfd_rt_stopwas passed the call-by-valuefd?Note that I'm not a C/NIF expert, so I hope I haven't missed some lifecycle nuances here.