WIP: Fixes weird bug in reactive transport tags#944
Open
ecoon wants to merge 9 commits into
Open
Conversation
Also removes some work-arounds in Amanzi PKs. This logic likely needs to be mirrored in Matrix reactive transport.
2b987dd to
0693570
Compare
Replace std::make_pair with emplace_back to avoid GCC 10.1+ C++17 parameter passing ABI compatibility warning. Also uses more efficient direct construction. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace std::make_pair with emplace_back/emplace in 13 locations to avoid GCC 10.1+ C++17 parameter passing ABI compatibility warnings. This addresses the same issue previously fixed in SolverNewton across all solver classes, mesh utilities, evaluators, and test code. Changes: - Solvers: SolverNKA, SolverNKA_BT, SolverLS, SolverAA - Mesh: MeshAudit_decl, MeshLogicalAudit - Evaluators: EvaluatorAperture, ModelEvaluator - Tests: mpc_utils, operator_virtual - ATS submodule: readMesh2D Direct construction is more efficient and avoids ABI issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace std::make_pair with brace initialization in return statements to avoid
GCC 10.1+ C++17 ABI compatibility warnings. This fixes the remaining warnings
that were occurring in function return values.
Changes:
- Evaluators: Porosity_Constant, Porosity_Compressible
- Utils: Brent root finding functions
- Mesh: MeshMaps, MeshFrameworkColumn, KDTree, MeshInternals_impl
Using brace initialization {a, b} instead of std::make_pair(a, b) avoids the
ABI issue and is cleaner C++17 code.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
@ecoon thanks for cleaning up the make_pair warnings. |
Add template emplace method to FIFO_Set that uses perfect forwarding to construct elements in-place. This allows avoiding the C++17 ABI compatibility warnings when inserting pairs into FIFO_Set containers. The emplace method constructs the element in-place using the provided arguments, checks for duplicates, and only adds if the element is unique, maintaining FIFO_Set semantics. The existing insert method is retained for backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes some work-arounds in Amanzi PKs.
WIP because this logic likely needs to be mirrored in Matrix reactive transport.