Skip to content

Add a help command#64

Open
Wilfred wants to merge 1 commit into
ananthakumaran:masterfrom
Wilfred:help-command
Open

Add a help command#64
Wilfred wants to merge 1 commit into
ananthakumaran:masterfrom
Wilfred:help-command

Conversation

@Wilfred

@Wilfred Wilfred commented Sep 21, 2018

Copy link
Copy Markdown
Collaborator

Using ? for help is a magit convention. Offer basic information on
keybindings by using Emacs' built-in help.

Fixes #59

Using ? for help is a magit convention. Offer basic information on
keybindings by using Emacs' built-in help.

Fixes ananthakumaran#59
@Wilfred

Wilfred commented Sep 21, 2018

Copy link
Copy Markdown
Collaborator Author

Hmm, this doesn't show all bindings, such as :.

@Bounga

Bounga commented Sep 21, 2018

Copy link
Copy Markdown
Collaborator

@Wilfred That's because you ask to show keybindings for monky-status-mode there's no : binding in this mode. That's a monky-mode binding.

I think that in monky-status we want to see both monky-mode and monky-status-mode bindings. When viewing logs we want to see both monky-mode and monky-log-mode bindings and so on.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants