This repository was archived by the owner on Feb 13, 2024. It is now read-only.
GL_SHADING_LANGUAGE_VERSION and EGL_RENDERABLE_TYPE#1877
Open
kuailexs wants to merge 3 commits into
Open
Conversation
Author
|
This is a palliative solution。Chrome and Webview Shell works |
morphis
suggested changes
Oct 20, 2021
morphis
left a comment
Member
There was a problem hiding this comment.
Left one small nitpick, otherwise LGTM
| }; | ||
|
|
||
| result = filter_extensions(result, whitelisted_extensions); | ||
| }else if (name == GL_SHADING_LANGUAGE_VERSION) { |
Member
There was a problem hiding this comment.
Can you add a space between } and else?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
was already approved by the maintainer 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webview will try to use Opengles3, but Anbox does not support it.
eglGetConfigAttrib(display_, config_, EGL_RENDERABLE_TYPE,
&config_renderable_type);
EGL_RENDERABLE_TYPE forced return EGL_OPENGL_ES2_BIT
see:
https://github.com/chromium/chromium/blob/67.0.3396.87/gpu/config/gpu_info_collector.cc#L160
https://github.com/chromium/chromium/blob/67.0.3396.87/ui/gl/gl_surface_egl.cc#L330
https://github.com/chromium/chromium/blob/67.0.3396.87/ui/gl/gl_context_egl.cc#L80
https://github.com/chromium/chromium/blob/67.0.3396.87/ui/gl/gl_context_egl.cc#L90