Config files#2038
Draft
m1dnight wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Needs to be rerolled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds config files for dev/test/prod. Jeremy noticed that the ports being used under test were the same as the ones in dev. I took the opportunity to create the proper config scaffolding now.
The idea is that configs under dev/test are generated at compiletime, and not at runtime. This makes sense because you run the dev/test in the repo itself, which causes a compile cycle every time anyway.