fix: bump python-tss-sdk to 2.0.0+ for Delinea Cloud Platform support#16446
Open
adrisala wants to merge 1 commit into
Open
fix: bump python-tss-sdk to 2.0.0+ for Delinea Cloud Platform support#16446adrisala wants to merge 1 commit into
adrisala wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR raises the minimum required version of ChangesDependency Version Constraint
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The bundled python-tss-sdk 1.2.x only supports the legacy /oauth2/token endpoint with grant_type=password. Delinea Cloud Platform tenants (*.delinea.app) require authentication via /identity/api/oauth2/token/xpmplatform with grant_type=client_credentials. SDK 2.0.0+ adds automatic server-type detection and the platform authentication flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8f6ce7a to
87e419b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python-tss-sdkminimum from>=1.2.1to>=2.0.0inrequirements.in/oauth2/tokenendpoint withgrant_type=password, which does not exist on Delinea Cloud Platform tenants (*.delinea.app)/identity/api/oauth2/token/xpmplatformwithgrant_type=client_credentialsrequirements.txtalready resolves to 2.0.0ISSUE TYPE
Test plan
*.delinea.apptenant🤖 Generated with Claude Code
Note
Low Risk
Low risk dependency constraint change confined to
requirements/requirements.in; main risk is unexpected behavior changes from the newerpython-tss-sdkmajor version in environments that previously installed 1.x.Overview
Updates the Python dependency floor for
python-tss-sdkfrom>=1.2.1to>=2.0.0inrequirements/requirements.in, ensuring installs use the newer SDK baseline.Reviewed by Cursor Bugbot for commit 87e419b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit