Make os.fsync() failure non-fatal. Needed on mounted CIFS file systems.#38
Open
dov wants to merge 1 commit into
Open
Make os.fsync() failure non-fatal. Needed on mounted CIFS file systems.#38dov wants to merge 1 commit into
dov wants to merge 1 commit into
Conversation
Signed-off-by: Dov Grobgeld <dov.grobgeld@gmail.com>
Member
|
Thanks for the help. In accordance with HACKING I've redirected this pull request to the list for discussion: https://groups.google.com/d/msg/bup-list/oJbemMZwnic/icvYnhJABAAJ |
kronenpj
approved these changes
Jan 31, 2018
kronenpj
left a comment
Contributor
There was a problem hiding this comment.
The exception could be more specific, OSError is what I see being thrown.
Contributor
|
There are some interesting 2009 posts by Linus Torvalds with potentially relevant clues about git/fsync/CIFS there and there. What I take away from those is that the real question usually is whether the code that actually does file updates does them such that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dov Grobgeld dov.grobgeld@gmail.com
Trying to do
os.fsync()on a CIFS mounted file system from Linux is not supported. This patch makes the failure non-fatal.