fix: show export button for unpublished results for support admins#6223
Open
KrissDrawing wants to merge 1 commit into
Open
fix: show export button for unpublished results for support admins#6223KrissDrawing wants to merge 1 commit into
KrissDrawing wants to merge 1 commit into
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-msq2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
@KrissDrawing I don't think this is the change they are requesting. But I just did a test without it and the support admin was able to export lottery data for waitlist lottery so I don't know what exactly they are asking for. I will ask for some more clarity from the Doorway team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1516
Description
That change doesn't really match request from the ticket, as that export view was not visible for both waitlist and available units, so i am not really sure if that was the correct change (maybe just one listing got published results and other not, and it confused the person creating the request).
Couldn't find any other place where it could have been a problem.
How Can This Be Tested/Reviewed?
Run lottery in partners app, but not publish it (both for waitlist and available units).
Log in to support admin account.
You should be able to see and export results on
http://localhost:3001/listings/[listingID]/lotteryAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: