Skip to content

Addresses CVE-2024-45337 CVE-2025-22868 CVE-2025-22869 CVE-2024-45338…#463

Open
spiliopoulos wants to merge 1 commit into
bojand:masterfrom
spiliopoulos:yannis_address_cves
Open

Addresses CVE-2024-45337 CVE-2025-22868 CVE-2025-22869 CVE-2024-45338…#463
spiliopoulos wants to merge 1 commit into
bojand:masterfrom
spiliopoulos:yannis_address_cves

Conversation

@spiliopoulos

Copy link
Copy Markdown

CVE-2025-22870 CVE-2025-22872 by upgrading crypto net and oauth

@spiliopoulos

Copy link
Copy Markdown
Author

The CVEs might not be exploitable for ghz or even significant for a tool like ghz but they do get flagged in corporate environments from automated scanners which make it harder to use and adopt. I understand that there is a toil associated with trying to keep up with dependencies and I hope that you will welcome PRs from third parties.

@spiliopoulos

Copy link
Copy Markdown
Author

@bojand I hope you might be able to take a look

@spiliopoulos

Copy link
Copy Markdown
Author

cc @jamiees2

@spiliopoulos spiliopoulos left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small explanation about a change

Comment thread runner/data_test.go
assert.NotNil(t, md1)
assert.Equal(t, []string{"1"}, md1.Get("token"))
assert.NotSame(t, mdp.preseed, md1)
assert.NotSame(t, &mdp.preseed, &md1)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testify addressed a bug in their implementation to be inline with their docs. Now NotSame expects pointers and fails otherwise.

I assume we were testing for instance equality rather than value equality here so I converted the values to pointers to the values.

@spiliopoulos

Copy link
Copy Markdown
Author

@bojand any updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant