This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fake-s3: support multiple hostnames / multi-homing#120
Open
megahall wants to merge 4 commits into
Open
Conversation
1c81fb3 to
43f08af
Compare
Author
|
UTs pass, ready to merge |
43f08af to
212da04
Compare
we need to add the arrays not add the hostnames as an extra element
fix hostnames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without multi-homing support, one cannot list all hostnames and IPs of the fake-s3 server.
Then, when connecting in various ways, especially via IP, the logic to detect the S3 calling format (
is_path_styleet. al.) behaves erroneously and tries to extract the bucket name from the hostname / domain name / IP first octet, which causes various malfunctions in naming and locating S3 buckets.