Skip to content

Handle nullable GitLab milestone due dates#322

Merged
Vacxe merged 1 commit into
danger:masterfrom
ult3mate:beer/fix/milestones-nullable
Feb 2, 2026
Merged

Handle nullable GitLab milestone due dates#322
Vacxe merged 1 commit into
danger:masterfrom
ult3mate:beer/fix/milestones-nullable

Conversation

@ult3mate

@ult3mate ult3mate commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Fixed a crash in the GitLab MR metadata parsing. Previously, setting a milestone without a due date triggered a JsonDecodingException because the parser encountered an unexpected null value.

This change marks the due_date field as optional/nullable to prevent decoding errors.

this is error log

JsonDecodingException: Unexpected Json token at offset 18834: Unexpected 'null' value instead of string literal at path: $.danger.gitlab.mr.milestone.due_date
Json input: .....0",
"due_date": null
"start_date":null
at kotlin.serialization.json.internal.JsonExceptionKt.JsonDecodingException(JsonExceptions.kt:24)
at kotlin.serialization.json.internal.JsonExceptionKt.JsonDecodingException(JsonExceptions.kt:32)

@Vacxe

Vacxe commented Feb 2, 2026

Copy link
Copy Markdown
Member

@ult3mate thanks for the contribution

@ult3mate ult3mate mentioned this pull request Feb 2, 2026
Closed
@Vacxe Vacxe merged commit b3f9c50 into danger:master Feb 2, 2026
1 of 3 checks passed
@PhompAng PhompAng mentioned this pull request Feb 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vacxe Vacxe Vacxe approved these changes

@f-meloni f-meloni Awaiting requested review from f-meloni f-meloni is a code owner

@gianluz gianluz Awaiting requested review from gianluz gianluz is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ult3mate @Vacxe