Docker volume plugin POC (WIP)#9
Conversation
|
I'm creating this draft primarily to get feedback on overall structure and the planned behavior for the plugin API in the PR description. Most of the changes made are just moving code around for easier reuse and setting up the build process, plugin.go is where the bulk of the actual new logic lives As of right now it's very incomplete and untested - I haven't written golang before, so I'm mostly wanting see if there are any glaring issues so I can make changes sooner rather than later. |
|
One alternate approach to the locking lifecycle would be to have /VolumeDriver.Create only create the dboxed volume but not the volume-mount / lock |
|
Hey @TheGeb. Thanks for creating the first PR in this project :) I tried to review the PR at least in regard to the structure of the changes. Here are a few things I noticed:
I remember that we shortly discussed where to put the docker volume plugin code when we first chatted on Reddit. Seeing this code, I now clearly prefer to to have it inside this repo (and not as an external contribution). There is however one thing that needs to be taken care of now: I initially considered having an external plugin that would invoke the dboxed CLI, which has the advantage that a crash inside a |
|
@TheGeb I've just created a Discord server that I also plan to use for dev coordination. If you're interested, you can join via the link on dboxed.io |
POC for docker volume plugin
Overview of behavior for each docker volume API function:
https://docs.docker.com/engine/extend/plugins_volume/#volume-plugin-protocol