Less verbose generator#9135
Draft
BraisGabin wants to merge 2 commits into
Draft
Conversation
Collaborator
7141493 to
e8cab63
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9135 +/- ##
============================================
- Coverage 85.04% 85.03% -0.01%
Complexity 4437 4437
============================================
Files 570 570
Lines 12322 12325 +3
Branches 2683 2684 +1
============================================
+ Hits 10479 10481 +2
Misses 680 680
- Partials 1163 1164 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
This PR is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now
detekt-generatorcli is verbose:At least it is only print in one task. But once #5855 is fixed it will be executed ~10 times so it is too noisy. This PR fixes that, the output is only shown if someone executes the
cliwith the--debugflag. And, by default, we are not going to make that.This is a draft because this nosie also show that fixing #5855 may make the full compilation a bit slower. I want to keep the noise there until #5855 is merged and we agree that #5855 is worth even with that slowdown.