This repository was archived by the owner on Feb 21, 2018. It is now read-only.
Add an explicit attribute collapsing specialization for two unused_types#4
Open
jktjkt wants to merge 1 commit into
Open
Add an explicit attribute collapsing specialization for two unused_types#4jktjkt wants to merge 1 commit into
jktjkt wants to merge 1 commit into
Conversation
Collaborator
|
Could you please reduce the test case to the bare minimum? For instance, you don't need a |
The test case is trying to ignore the attribute of the CRLF rule. Without the patch to make_attribute.hpp, the compiler doesn't know which of the specializations to use, and the build fails.
Collaborator
|
I was able to reduce the test case to a minimum: Note that it belongs in rule* and not in sequence. |
Owner
|
I just migrated X3 to the boost repository. Please have your pull request there. This repo is going away. (https://github.com/boostorg/spirit/tree/develop) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test case is trying to ignore the attribute of the CRLF rule. Without the
patch to make_attribute.hpp, the compiler doesn't know which of the
specializations to use, and the build fails.